[Webkit-unassigned] [Bug 191650] [Curl] Fix Curl Request Scheduler not to release wrong Curl handle when request is cancelled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 22 06:47:47 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=191650

--- Comment #15 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #12)
> (In reply to Takashi Komori from comment #11)
> > (In reply to Fujii Hironori from comment #7)
> > > I got it. Thank you for the explanation.
> > > m_cancelled is accessed from both threads without locking a mutex.
> > 
> > FIXED.
> 
> Hmm, it looks badly designed to me.
> What about m_curlHandle? 
> m_curlHandle is written in CurlRequest::setupTransfer in curl thread,
> but accessed in main thread in CurlRequest::cancel via
> isCompletedOrCancelled.

Before patch CurlRequest::cancel was using isCompletedOrCancelled but with new patch it isn't using.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190422/b19002b7/attachment.html>


More information about the webkit-unassigned mailing list