[Webkit-unassigned] [Bug 191650] [Curl] Fix Curl Request Scheduler not to release wrong Curl handle when request is cancelled.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 19 01:18:44 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=191650

--- Comment #10 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #5)
> Comment on attachment 367302 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367302&action=review
> 
> > Source/WebCore/platform/network/curl/CurlRequestScheduler.h:71
> > +    HashSet<CurlRequestSchedulerClient*> m_activeJobs;
> 
> You can remove  m_activeJobs By using m_clientMaps with client->handle().

To control thread stopping CurlRequestScheduler::stopThreadIfNoMoreJobRunning() is using m_activeJobs.
Because Client with null CURL handle can exist (when setupTransfer failed), using m_clientMap for this purpose seems to be difficult.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190419/05ba4170/attachment.html>


More information about the webkit-unassigned mailing list