[Webkit-unassigned] [Bug 196934] New: Add cleaning of sent ad click conversions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 14:29:34 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=196934

            Bug ID: 196934
           Summary: Add cleaning of sent ad click conversions
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wilander at apple.com

We should clean the Map in WebKit::AdClickAttributionManager from attributions that have already been converted and sent out.

The fix should cover these comments on the patch in https://bugs.webkit.org/show_bug.cgi?id=196838:

Instead of having one big m_adClickAttributionMap map, it might be better to have two maps:
- One for not yet converted ad click attributions
- One for converted ad click attributions that are pending being sent.
Here, we would only iterate over the second one, which would make earliestTimeToSend always available.

Maybe that would call for two structures, one with an earliestTimeToSend and one without.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190415/c07d97d6/attachment.html>


More information about the webkit-unassigned mailing list