[Webkit-unassigned] [Bug 196855] Fix Covscan uninitialized after ctor

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 15 09:25:23 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=196855

--- Comment #30 from Darin Adler <darin at apple.com> ---
(In reply to Eike Rathke from comment #29)
> Oh, you sort not initializing under coding style, ah well.. wasn't aware of
> that.

That’s an incorrect characterization of my view. Here’s my view:

Initializing something that is *used* is absolutely required, not a coding style decision. Many of the changes in this patch repair those kinds of problems and we must take those changes as soon as possible.

Initializing something that is *not* used is a coding style decision. Some advocate this style, citing that it’s safer to initialize everything and is unlikely to have any major negative impact or cost. Others advocate a style where we initialize only in cases where the initialization is meaningful, citing possible performance benefits in cases where the compiler can’t see the fact that the value is never used, or preferring not to write code that has no effect by setting an initial value that is provably irrelevant since it is only written and never read.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190415/5e480729/attachment.html>


More information about the webkit-unassigned mailing list