[Webkit-unassigned] [Bug 196855] Fix Covscan uninitialized after ctor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196855

Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfulgham at webkit.org

--- Comment #21 from Alexey Proskuryakov <ap at webkit.org> ---
> No, exactly that. But then again.. is it really scanned?

I do not know. The access is restricted, and IIRC I never had access. Worth discussing on the webkit-security list, not in this bug.

> It's not unnecessary, though. It's fixing a real bug. The first time
> GradientImage::drawPattern is called, m_cachedGeneratorHash is read
> uninitialized.

The code is actually correct. The first time this function is called, m_cachedImage is null, so the rest of the expression is not evaluated (it's called short-circuiting logical operators in C++).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190412/e006c7ae/attachment.html>