[Webkit-unassigned] [Bug 196855] Fix Covscan uninitialized after ctor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196855

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 367314
  --> https://bugs.webkit.org/attachment.cgi?id=367314
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367314&action=review

I really appreciate the time an effort to run Coverity and fix everything it finds.

This patch includes fixes for some real bugs, and some cases where Coverity effectively just prefers a different coding style. The Coverity coding style may be safer, but we don’t necessarily want to make that kind of a change without a discussion first.

Generally we would not land a patch, especially from a non-contributor, without discussion.

I started looking at the changes in the patch to check them for correctness and value but didn’t have a chance to review the whole thing, just started looking at a couple.

> Source/WebCore/html/HTMLMediaElement.cpp:2105
> -        if (actionIfInvalid == Complain)
> +        if (actionIfInvalid == Complain) {
>              FrameLoader::reportLocalLoadFailed(frame.get(), url.stringCenterEllipsizedToLength());
>              ERROR_LOG(LOGIDENTIFIER, url , " was rejected by SecurityOrigin");
> +        }
>          return false;

Good fix, but a different Coverity error, not uninitialized data members.

> Source/WebCore/html/HTMLMenuElement.h:43
> -    bool m_isTouchBarMenu;
> +    bool m_isTouchBarMenu { false };

Definitely a real bug here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190412/59956b0e/attachment-0001.html>