[Webkit-unassigned] [Bug 196827] Take an assertion if there is open database connection

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 11 13:29:16 PDT 2019


https://bugs.webkit.org/show_bug.cgi?id=196827

--- Comment #4 from Sihui Liu <sihui_liu at apple.com> ---
(In reply to Chris Dumez from comment #2)
> My understanding was that it is OK to suspend while databases are open. It
> is only not OK when there are pending transactions because the database file
> is locked when there is an operation running.
> 
> I believe holding an assertion whenever there is an open database would be a
> significant power regression.

I thought about this. If this is the case, why do we closeAllDatabases when ProcessWillSuspendImminently? We could just let the running transaction be finished or interrupted?

Also, if this causes big power regression, shouldn't we find all the places that could have database connection open for a long time but not actually doing anything and close them? I was told we are not supposed to keep open database connection when there is no database activity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190411/8eb5adec/attachment.html>


More information about the webkit-unassigned mailing list