[Webkit-unassigned] [Bug 196811] New: [WPE] Build error with ENABLE_VIDEO=OFF after r244078

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196811

            Bug ID: 196811
           Summary: [WPE] Build error with ENABLE_VIDEO=OFF after r244078
           Product: WebKit
           Version: WebKit Local Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: psaavedra at igalia.com

An alternative local nightly build of the WPE port fails after changes introduced in r244078:


commit 570b1231363977e8a48ac6bee26aa775a94309ac
Author: jer.noble at apple.com <jer.noble at apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Date:   Tue Apr 9 15:57:45 2019 +0000

    Source/WebCore:
    Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
    https://bugs.webkit.org/show_bug.cgi?id=196097

    Reviewed by Eric Carlson.

    Test: media/track/track-in-band-metadata-display-order.html

    Add a method in Internals to create a TextTrackCueGeneric (which can normally only be created
    by parsing an in-band media track). This requires adding IDL for TextTrackCueGeneric, and exporting
    TextTrackCueGeneric for testing.

    Drive-by fixes:

    Add runtime logging to MediaControlTextTrackContainerElement. This necessitates modifying the
    parentMediaElement() method to take a const Node*, and const_cast that constness away in order to return
    a HTMLMediaElement*

    TextTrackCue, VTTCue, TextTrackCueGeneric, and DataCue should all use the WTF TypeCasts macros to
    enable use of is<> and downcast<>.



Error:


In file included from DerivedSources/ForwardingHeaders/wtf/HashFunctions.h:26,
                 from DerivedSources/WebCore/CSSPropertyNames.h:7,
                 from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/css/CSSStyleDeclaration.h:23,
                 from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/css/CSSComputedStyleDeclaration.h:23,
                 from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.h:29,
                 from /home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.cpp:28:
DerivedSources/ForwardingHeaders/wtf/RefPtr.h: In instantiation of 'void WTF::refIfNotNull(T*) [with T = WebCore::TextTrackCueGeneric]':
DerivedSources/ForwardingHeaders/wtf/RefPtr.h:57:61:   required from 'WTF::RefPtr<T, <template-parameter-1-2> >::RefPtr(T*) [with T = WebCore::TextTrackCueGeneric; PtrTraits = WTF::DumbPtrTraits<WebCore::TextTrackCueGeneric>]'
/home/igalia/psaavedra/yocto-wandboard-wpe/builds/wandboard-mesa-wpe-alternative/tmp/work/armv7at2hf-neon-imx-poky-linux-gnueabi/wpewebkit/nightly-AUTOINC+2e3d2042f6-r0/git/Source/WebCore/testing/Internals.cpp:3584:16:   required from here
DerivedSources/ForwardingHeaders/wtf/RefPtr.h:38:14: error: invalid use of incomplete type 'class WebCore::TextTrackCueGeneric'



git blame Source/WebCore/html/InputType.h
...
b54d1c8871e1 (eric.carlson at apple.com      2013-02-12 06:30:19 +0000  213) #if ENABLE(VIDEO_TRACK)
b54d1c8871e1 (eric.carlson at apple.com      2013-02-12 06:30:19 +0000  214) #include "CaptionUserPreferences.h"
b54d1c8871e1 (eric.carlson at apple.com      2013-02-12 06:30:19 +0000  215) #include "PageGroup.h"
570b12313639 (jer.noble at apple.com         2019-04-09 15:57:45 +0000  216) #include "TextTrackCueGeneric.h"
b54d1c8871e1 (eric.carlson at apple.com      2013-02-12 06:30:19 +0000  217) #endif


TextTrackCueGeneric headers are only included when VIDEO_TRACK is enabled and this is only enabled when VIDEO is enabled as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190411/2bf4f7b4/attachment-0001.html>