[Webkit-unassigned] [Bug 196488] [CMake] Detect SSE2 at compile time

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196488

--- Comment #14 from Konstantin Tokarev <annulen at yandex.ru> ---
(In reply to Xan Lopez from comment #12)
> (In reply to Konstantin Tokarev from comment #11)
> > Comment on attachment 366492 [details]
> > Detect SSE2 with CMake
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=366492&action=review
> > 
> > > CMakeLists.txt:123
> > > +        message(FATAL_ERROR "SSE2 support is required to compile WebKit")
> > 
> > This is wrong, we should switch to CLoop if SSE2 is not supported, otherwise
> > add -msse2 to cflags
> 
> The flags are added in webkitdirs.pm. We are effectively requriring SSE2 to
> run WebKit now (see bug #194853 and the thread in webkit-dev linked from
> there). 

My point is that we should't require SSE2 because we don't have to use JIT. Or this check should be guarget by if(ENABLE_JIT AND WTF_CPU_X86), which may align better with our policy of failing eagerly instead of degrading features silently based on system detection

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190410/7e3a4d6b/attachment.html>