[Webkit-unassigned] [Bug 196727] [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196727

--- Comment #4 from Takashi Komori <Takashi.Komori at sony.com> ---
(In reply to Fujii Hironori from comment #2)
> Comment on attachment 367033 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=367033&action=review
> 
> > Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113
> > +    auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get());
> WebKitBrowserWindow is used only for WinCairo at the memoment, but also for
> AppleWin in the future (hopefully). Should be renamed.

Changed to "WinMiniBrowser". If more apropriate one exists, I'll change.

> Nit: pageGroup is leaked.
> auto pageGroup = adoptWK(...);
> And conf, prefs and context are also leaked.

Fixed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190410/864c652f/attachment.html>