[Webkit-unassigned] [Bug 196746] New: We should clear m_needsOverflowCheck when hitting an exception in defineProperties in ObjectConstructor.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196746

            Bug ID: 196746
           Summary: We should clear m_needsOverflowCheck when hitting an
                    exception in defineProperties in ObjectConstructor.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: rmorisset at apple.com

Currently we correctly do so when toPropertyDescriptor fails, but not when properties->get(exec, propertyNames[i]); does.
This can turn an OOM into a crash, because of the check in ~MarkedArgumentBuffer.
The fix is a trivial call to markBuffer.overflowCheckNotNeeded() on that path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190409/27314c67/attachment.html>