[Webkit-unassigned] [Bug 196727] [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196727

Fujii Hironori <Hironori.Fujii at sony.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #367033|review?                     |review-
              Flags|                            |

--- Comment #2 from Fujii Hironori <Hironori.Fujii at sony.com> ---
Comment on attachment 367033
  --> https://bugs.webkit.org/attachment.cgi?id=367033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367033&action=review

> Tools/MiniBrowser/win/WebKitBrowserWindow.cpp:113
> +    auto pageGroup = WKPageGroupCreateWithIdentifier(createWKString("WinCairoMiniBrowser").get());

WebKitBrowserWindow is used only for WinCairo at the memoment, but also for AppleWin in the future (hopefully). Should be renamed.
Nit: pageGroup is leaked.
auto pageGroup = adoptWK(...);
And conf, prefs and context are also leaked.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190409/87f14379/attachment-0001.html>