[Webkit-unassigned] [Bug 195537] Multiple File Input Icon Set Regardless of File List
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 8 16:49:49 PDT 2019
https://bugs.webkit.org/show_bug.cgi?id=195537
--- Comment #36 from Alexey Proskuryakov <ap at webkit.org> ---
> As far as Iv'e read, the APIs for getting the icon representation of a collection of files is part of UIKit, and therefore will require us getting through Objective C code to call it. I wanted to avoid that for now.
I see. Typically, we just put the implementation in a nearby .mm file (e.g. FooClass.cpp and FooClassCocoa.mm or FooClassIOS.mm). Of course, this means that other platforms need an implementation too, if only a stub.
> Creating a *media* (with display string and icon) file list and creating a normal file list are different flows
Sounds reasonable, I'll leave this to someone familiar with this separate flow to review.
It is nice that the test ends up being more cross platform because the icon is hardcoded.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190408/2e7dff84/attachment.html>
More information about the webkit-unassigned
mailing list