[Webkit-unassigned] [Bug 196703] New: [CMake] Audit uses of set_source_files_properties

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196703

            Bug ID: 196703
           Summary: [CMake] Audit uses of set_source_files_properties
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CMake
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mcatanzaro at igalia.com

We should audit all uses of set_source_files_properties as they're likely broken. They can only work for source files excluded from unified build (either with @no-unify or by not being listed in Sources.txt).

Source/JavaScriptCore/CMakeLists.txt:    set_source_files_properties(builtins/BuiltinNames.cpp PROPERTIES COMPILE_FLAGS -fno-var-tracking-assignments)
Source/JavaScriptCore/shell/PlatformMac.cmake:set_source_files_properties(${TESTAPI_OBJC_SOURCES} PROPERTIES COMPILE_FLAGS -fobjc-arc)
Source/ThirdParty/libwebrtc/Source/third_party/protobuf/cmake/protobuf-module.cmake.in:  set_source_files_properties(${${SRCS}} ${${HDRS}} PROPERTIES GENERATED TRUE)
Source/ThirdParty/openvr/src/CMakeLists.txt:    set_source_files_properties(vrcommon/pathtools_public.cpp vrcommon/vrpathregistry_public.cpp PROPERTIES COMPILE_FLAGS "-x objective-c++")
Source/WebCore/ChangeLog-2015-11-21:        because CMake can only set COMPILE_FLAGS once with set_source_files_properties, and we want 
Source/WebCore/platform/GStreamer.cmake:    set_source_files_properties(platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp PROPERTIES COMPILE_DEFINITIONS "GLIB_DISABLE_DEPRECATION_WARNINGS=1")
Source/WebKitLegacy/PlatformMac.cmake:        set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-ObjC++ -std=c++17")
Source/WebKitLegacy/PlatformMac.cmake:        set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS -std=c99)
Source/WebKitLegacy/PlatformWin.cmake:    set_source_files_properties(${DERIVED_SOURCES_WEBKITLEGACY_DIR}/Interfaces/${_filewe}.h PROPERTIES GENERATED TRUE)
Source/WebKitLegacy/PlatformWin.cmake:    set_source_files_properties(${DERIVED_SOURCES_WEBKITLEGACY_DIR}/Interfaces/${_filewe}_i.c PROPERTIES GENERATED TRUE)
Source/cmake/WebKitMacros.cmake:            set_source_files_properties(${_sourceFileTmp} PROPERTIES HEADER_FILE_ONLY ON)
Source/cmake/WebKitMacros.cmake:    set_source_files_properties(${_source} PROPERTIES OBJECT_DEPENDS "${_tmp}")
Source/cmake/WebKitMacros.cmake:            set_source_files_properties(${_cpp}
Source/cmake/WebKitMacros.cmake:            set_source_files_properties(${_cpp}
Source/cmake/WebKitMacros.cmake:        set_source_files_properties(${_sources}
Tools/DumpRenderTree/PlatformMac.cmake:    set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-std=c99")
Tools/DumpRenderTree/PlatformMac.cmake:    set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-std=c++17")
Tools/DumpRenderTree/PlatformMac.cmake:    set_source_files_properties(${_file} PROPERTIES COMPILE_FLAGS "-ObjC++ -std=c++17")
Tools/Scripts/webkitpy/style/checkers/cmake.py:        'set_source_files_properties', 'set_target_properties',

It's good we have a style checker rule for it, at least.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190408/1738e2f5/attachment-0001.html>