[Webkit-unassigned] [Bug 196622] [WinCairo] Move to Visual Studio 2019

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196622

--- Comment #17 from Stephan Szabo <stephan.szabo at sony.com> ---
(In reply to Fujii Hironori from comment #12)
> (In reply to Stephan Szabo from comment #9)
> > It seems to me that the same condition of using different versions could
> > happen with VSINSTALLDIR as well as cmake doesn't always obey that variable
> > as far as I can see from
> > https://gitlab.kitware.com/cmake/cmake/blob/master/Source/cmVSSetupHelper.cxx
> 
> What is your idea addressing the version mismatch issue (Bug 190797 comment
> 21)?

Can we agree on the following?
A) If one runs the vcvars script in the shell, we shouldn't use vswhere to find one.
B) Therefore, the only time we use vswhere is when the vcvars environment is not set up and we have to try to find one
C) If vcvars was not run, setting VSINSTALLDIR is insufficient, so the use of VSINSTALLDIR alone in the script is itself insufficient to guarantee matching:
===
C:\github\tests\cmake-basic-test\foo>set VSINSTALLDIR=C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\

C:\github\tests\cmake-basic-test\foo>cmake -G "Visual Studio 15" ..
-- The C compiler identification is MSVC 19.14.26433.0
-- The CXX compiler identification is MSVC 19.14.26433.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Professional/VC/Tools/MSVC/14.14.26428/bin/Hostx86/x86/cl.exe
===

If we can agree on the above, then my thought sequence would be:
D) We'd like to cover as many cases as possible
E) And we would like to make it easy to be able to switch between ports without requiring the user the also switch between shells.
F) So, we try to find a compiler that'll match as best we can for the case that the user isn't giving us a configured environment
G) And we allow users to use vcvars shells to cover any cases we've not yet covered explicitly.
H) And we try to over time minimize the cases where the difference occurs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190405/88b7b2e4/attachment.html>