[Webkit-unassigned] [Bug 196644] Combine event and touch action regions into a single class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=196644

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com
 Attachment #366816|review?                     |review+
              Flags|                            |

--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 366816
  --> https://bugs.webkit.org/attachment.cgi?id=366816
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366816&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h:127
> +    WEBCORE_EXPORT void setEventRegion(EventRegion&&) override;

Kind of surprised that these are override and not final. Maybe still a confusing area of C++ for our coding conventions?

> Source/WebCore/rendering/EventRegion.cpp:112
> +        if (m_touchActionRegions.size() < index + 1)
> +            m_touchActionRegions.grow(index + 1);

Not new: Seems like Vector should have this operation instead of it being two function calls.

> Source/WebCore/rendering/EventRegion.cpp:132
>              if (action == TouchAction::None || action == TouchAction::Manipulation)

Not new: Does this require that "none" and "manipulation" be earlier in the enumeration than any other actions? If so, then maybe static_assert that here?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190405/ea1dbbad/attachment-0001.html>