[Webkit-unassigned] [Bug 181228] Web Inspector: [GTK] Copy copies to nowhere

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=181228

--- Comment #7 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Joseph Pecoraro from comment #5)
> Comment on attachment 366482 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366482&action=review
> 
> >> Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp:158
> >> +        case CheckableActionType: {
> > 
> > Is there no complaint from -Wimplicit-fallthrough? We have a FALLTHROUGH macro that expands to a suitable attribute to avoid warnings here:
> > 
> > case ActionType:
> >     FALLTHROUGH;
> > case CheckableActionType: {
> 
> FALLTHROUGH is normally only necessary if there has been some statement
> between case statements. Here they are grouped directly next to each other
> so it probably won't be necessary.

Exactly, FALLTHROUGH is for the cases where it's not obvious if you want to fall through or you forgot to add the break. That's not the case here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190403/82823b28/attachment-0001.html>