[Webkit-unassigned] [Bug 195902] Update event region when toggling pointer-events:none

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=195902

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com
 Attachment #366403|1                           |0
        is obsolete|                            |

--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 366403
  --> https://bugs.webkit.org/attachment.cgi?id=366403
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366403&action=review

> Source/WebCore/ChangeLog:12
> +        Normally paint invalidation requests compositing configuration update whenever anything that would
> +        affect event region changes. However mutating 'pointer-events' property does not cause paint invalidation.

Maybe RenderStyle::diff should return an enum value that indicates that event regions are dirty?

> Source/WebCore/rendering/RenderElement.cpp:737
> +            if (layer && (layer = layer->enclosingCompositingLayerForRepaint()))
> +                layer->setNeedsCompositingConfigurationUpdate();

It's non-obvious that setNeedsCompositingConfigurationUpdate is what you call to get event regions to be recomputed. We should clean that up in future.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20190401/1a20954f/attachment.html>