[Webkit-unassigned] [Bug 188834] AudioNode.connect does not return destination node

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188834

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #7 from Darin Adler <darin at apple.com> ---
Comment on attachment 351198
  --> https://bugs.webkit.org/attachment.cgi?id=351198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351198&action=review

> Source/WebCore/Modules/webaudio/AudioNode.idl:37
> -    [MayThrowException] void connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);
> +    [MayThrowException] AudioNode connect(AudioNode destination, optional unsigned long output = 0, optional unsigned long input = 0);

I believe there is a slightly more efficient way to do this by using the [ReturnValue] attribute on the destination object, so the JavaScript binding will reuse the passed-in wrapper rather than having to look it up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20181001/7311b4c3/attachment.html>