[Webkit-unassigned] [Bug 190010] Split NaN-check into separate test

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=190010

Saam Barati <sbarati at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350900|review?                     |review+
              Flags|                            |

--- Comment #2 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 350900
  --> https://bugs.webkit.org/attachment.cgi?id=350900
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350900&action=review

> JSTests/ChangeLog:9
> +        DataView exposes NaN-representation, which is not necessarily the same on each
> +        architecture. Therefore move the check of the NaN-representation into its own
> +        file such that we can disable this test on MIPS where NaN-representation can be
> +        different on older CPUs.

nit: Please move this underneath the "Reviewed by"

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180927/7f8faa11/attachment-0001.html>