[Webkit-unassigned] [Bug 189991] New: [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189991

            Bug ID: 189991
           Summary: [WTF] Add ExternalStringImpl, a StringImpl for user
                    controlled buffers
           Product: WebKit
           Version: Other
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Template Framework
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: koby.b at mce.systems

Created attachment 350859

  --> https://bugs.webkit.org/attachment.cgi?id=350859&action=review

run-javascriptcore-tests output

Hi,
In node-jsc, to match v8's string api, I needed to be able to allocate JSStrings with buffers managed externally, meaning they are allocated by the api users and should be freed by them when the JSString is destructed.
To support this is JSC\WTF, I've added WTF::ExternalStringImpl, a subclass of StringImpl which calls a custom free function when it's destructed (and always creates the StringImpl with ConstructWithoutCopying).

Regarding tests:
- I ran TestWTF (on macOS). String related tests have passed, I only got a few failures regarding HashMap (which I guess are not related).
- I ran run-javascriptcore-tests (on macOS). There were a few failures but if I'm reading the output correctly I only was two "FAILED" FTL related tests. I've attached the output.
- According to https://webkit.org/contributing-code/, I should run run-webkit-tests for regression tests, but I still can't get it to run. It fails to run on macOS and Windows (I've created a bug for macOS), and I'm still trying to get everything compiled on an ubuntu machine (gtk build fails with an "internal compiler error", I'll create a bug for that). Is it really mandatory for every patch? If it is, I would love some advice on where to put my efforts into, as it's been a bit frustrating. This is the second patch from node-jsc I'm sending, and I have quite a few more, and I would love to get a working test setup so I could start sending them :)

Thanks
Koby

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180926/f20d1f01/attachment-0001.html>