[Webkit-unassigned] [Bug 189695] REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on iOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189695

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350750|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 350750
  --> https://bugs.webkit.org/attachment.cgi?id=350750
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350750&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1704
> +    [self _processWillChange];

It's weird that "process did exit" calls "process will change". _processWillChange implies we're still attached to the old process but are about to switch.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:165
> +    if (!m_drawingArea)
> +        return;

Blank line after the return please.

> Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeHost.mm:185
> +    if (!m_drawingArea)
> +        return;

Blank line after the return please.

> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:216
> +    [m_contentView _processDidExit];
> +    [m_webView _processWillSwap];

Please keep the contentView and webView methods the same.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180925/7312973c/attachment.html>