[Webkit-unassigned] [Bug 189822] Apache can return a corrupt manifest file while ManifestGenerator::store is running

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189822

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350736|review?                     |review+
              Flags|                            |

--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 350736
  --> https://bugs.webkit.org/attachment.cgi?id=350736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350736&action=review

> Websites/perf.webkit.org/ChangeLog:8
> +        Updating a file on should be transactional between php and apache.

Updating a file *on* what??

> Websites/perf.webkit.org/ChangeLog:11
> +        * public/api/measurement-set.php: Adapted invocation of 'generate_json_date_with_elapsed_time_if needed'.

Nit: Somehow the function name has a space instead of _ between if and needed.

> Websites/perf.webkit.org/ChangeLog:12
> +        * public/api/runs.php: Adapted invocation of 'generate_json_date_with_elapsed_time_if needed'.

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180925/5198f826/attachment.html>