[Webkit-unassigned] [Bug 189822] Apache can return a corrupt manifest file while ManifestGenerator::store is running

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 24 15:21:53 PDT 2018


--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 350341
  --> https://bugs.webkit.org/attachment.cgi?id=350341

View in context: https://bugs.webkit.org/attachment.cgi?id=350341&action=review

>>> Websites/perf.webkit.org/public/api/measurement-set.php:55
>>> +        generate_json_data_conditionally($cache_filename, $json, 'elapsedTime');
>> I don't think we want to rely on elapsedTime being the last item like this.
>> Pass in $elapsed_time as the last argument to generate_json_data_conditionally instead:
>> generate_json_data_conditionally($cache_filename, $content, $elapsed_time);
>> It's better to invoke json_encode in generate_json_data_conditionally instead.
>> Also, we should probably call this generate_json_data_if_needed to match the naming convention used elsewhere in WebKit.
> If do so, we need to make generate_json_date_conditinally returns an encoded json to void calling json_encode twice as it is needed in Lin 58.

Yeah, that's fine.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180924/e4e21c2e/attachment.html>

More information about the webkit-unassigned mailing list