[Webkit-unassigned] [Bug 189894] New: Add missing includes in TextCodecReplacement.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189894

            Bug ID: 189894
           Summary: Add missing includes in TextCodecReplacement.cpp
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fred.wang at free.fr
                CC: lforschler at apple.com
            Blocks: 188043

Patch from bug 188043 exhibits a possible build error when with unifiedbuild source rotating:

In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
./platform/text/TextCodecReplacement.cpp:49:30: error: implicit instantiation of undefined template 'WTF::Function<std::__1::unique_ptr<WebCore::TextCodec, std::__1::default_delete<WebCore::TextCodec> > ()>'
    registrar("replacement", [] {
                             ^
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
In file included from ./platform/text/TextCodecReplacement.cpp:27:
In file included from ./platform/text/TextCodecReplacement.h:28:
In file included from ./platform/text/TextCodecUTF8.h:28:
In file included from ./platform/text/TextCodec.h:33:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:53:26: note: template is declared here
template<typename> class Function;
                         ^
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
./platform/text/TextCodecReplacement.cpp:49:30: note: candidate function
    registrar("replacement", [] {
                             ^
./platform/text/TextCodecReplacement.cpp:54:30: error: incomplete result type 'WTF::String' in function definition
String TextCodecReplacement::decode(const char*, size_t, bool, bool, bool& sawError)
                             ^
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
In file included from ./platform/text/TextCodecReplacement.cpp:27:
In file included from ./platform/text/TextCodecReplacement.h:28:
In file included from ./platform/text/TextCodecUTF8.h:28:
In file included from ./platform/text/TextCodec.h:33:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String'
class String;
      ^
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
./platform/text/TextCodecReplacement.cpp:58:16: error: use of undeclared identifier 'emptyString'
        return emptyString();
               ^
./platform/text/TextCodecReplacement.cpp:60:12: error: invalid use of incomplete type 'WTF::String'
    return String { &replacementCharacter, 1 };
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource357.cpp:1:
In file included from ./platform/text/TextCodecReplacement.cpp:27:
In file included from ./platform/text/TextCodecReplacement.h:28:
In file included from ./platform/text/TextCodecUTF8.h:28:
In file included from ./platform/text/TextCodec.h:33:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/usr/local/include/wtf/Forward.h:39:7: note: forward declaration of 'WTF::String'
class String;
      ^
4 errors generated.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=188043
[Bug 188043] Add support for ScrollOptions' ScrollBehavior and CSS scroll-behavior properties
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180923/a1b7ac61/attachment.html>