[Webkit-unassigned] [Bug 188696] beforeunload interoperability issues

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Sep 22 03:12:51 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
 Attachment #350504|review?                     |review-
              Flags|                            |

--- Comment #31 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 350504
  --> https://bugs.webkit.org/attachment.cgi?id=350504

View in context: https://bugs.webkit.org/attachment.cgi?id=350504&action=review

> Source/WebCore/ChangeLog:7
> +

The change log should state why we're making this change, reference relevant spec text, and explain how we're implementing that.
r- due to the lack of the change log description.

> LayoutTests/ChangeLog:9
> +        Had to remove the event listeners once the test is done, otherwise
> +        they would show a beforeunload alert on the next test for some reason.

We should investigate why that's happening and fix WebCore / WebKitTestRunner / DumpRenderTree instead of updating tests.
r- because of this.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180922/0fcdab65/attachment.html>

More information about the webkit-unassigned mailing list