[Webkit-unassigned] [Bug 189663] REGRESSION (PSON): White or Black flash occurs when process swapping on navigation on Mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189663

--- Comment #25 from Chris Dumez <cdumez at apple.com> ---
(In reply to Chris Dumez from comment #24)
> (In reply to Antti Koivisto from comment #23)
> > > > Source/WebKit/UIProcess/WebPageProxy.cpp:2454
> > > > +            process().send(Messages::WebPage::SetIsSuspended(true), pageID());
> > > 
> > > I am wondering if we still need this IPC given that the WebProcess already
> > > gets a Policy decision IPC with PolicyAction::Suspend. Also, with your
> > > change, SetIsSuspended(true) IPC is sent twice to the process I believe.
> > 
> > The message from SuspendedPageProxy constructor comes too late (trip to
> > runloop puts it after the policy delegate) as the page will have already
> > transitioned to about:blank at that point. We need to tell the process
> > immediately that it suspended so it knows to keep the layer tree frozen.
> > 
> > I didn't remove the second message as it was harmless but maybe I should.
> 
> You misunderstanding my comment. We already send a policy decision IPC to
> the WebProcesss with PolicyAction::Suspend, in the same method where you now
> send the 
> WebPage::SetIsSuspended(true) IPC. Therefore, the WebProcess, could use the
> existing IPC as signal that it is suspended.
> 

I am referring to WebPage::didReceivePolicyDecision() which gets called with PolicyAction::Suspend in case of process swap, which we already use as signal to navigate to about:blank.

> > 
> > > > Source/WebKit/mac/postprocess-framework-headers.sh:56
> > > > +        IOS_VERSION="12.0"
> > > 
> > > Why this change?
> > 
> > Build hack I forgot to remove.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180919/dbb308a4/attachment.html>