[Webkit-unassigned] [Bug 189694] Implement CSS Custom Properties and Values Skeleton

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189694

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #350120|review?                     |review+
              Flags|                            |

--- Comment #14 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 350120
  --> https://bugs.webkit.org/attachment.cgi?id=350120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350120&action=review

> Source/WebCore/css/DOMCSSCustomPropertyDescriptor.h:15
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above
> + *    copyright notice, this list of conditions and the following disclaimer in
> + *    the documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of Motorola Mobility Inc. nor the names of its
> + *    contributors may be used to endorse or promote products derived from this
> + *    software without specific prior written permission.

Wrong license.

> Source/WebCore/css/DOMCSSCustomPropertyDescriptor.idl:15
> +* 1. Redistributions of source code must retain the above copyright
> +*    notice, this list of conditions and the following disclaimer.
> +* 2. Redistributions in binary form must reproduce the above
> +*    copyright notice, this list of conditions and the following disclaimer in
> +*    the documentation and/or other materials provided with the distribution.
> +* 3. Neither the name of Motorola Mobility Inc. nor the names of its
> +*    contributors may be used to endorse or promote products derived from this
> +*    software without specific prior written permission.

Wrong license.

> Source/WebCore/css/DOMCSSRegisterCustomProperty.cpp:15
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above
> + *    copyright notice, this list of conditions and the following disclaimer in
> + *    the documentation and/or other materials provided with the distribution.
> + * 3. Neither the name of Motorola Mobility Inc. nor the names of its
> + *    contributors may be used to endorse or promote products derived from this
> + *    software without specific prior written permission.

Wrong license.

> Source/WebCore/css/DOMCSSRegisterCustomProperty.h:2
> + * Copyright (C) 2012 Motorola Mobility Inc. All rights reserved.

Apple

> Source/WebCore/dom/Document.h:2029
> +    HashMap<String, CSSRegisteredCustomProperty> m_CSSRegisteredPropertySet;

Probably want a HashMap<String, std::unique_ptr<CSSRegisteredCustomProperty>> at some point.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180919/ff607eeb/attachment.html>