[Webkit-unassigned] [Bug 189740] [EME] Add WebM sanitization
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 19 08:33:59 PDT 2018
https://bugs.webkit.org/show_bug.cgi?id=189740
Xabier RodrÃguez Calvar <calvaris at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #350106| |review+
Flags| |
--- Comment #3 from Xabier RodrÃguez Calvar <calvaris at igalia.com> ---
Comment on attachment 350106
--> https://bugs.webkit.org/attachment.cgi?id=350106
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=350106&action=review
> Source/WebCore/ChangeLog:10
> + see https://www.w3.org/TR/encrypted-media/#dom-mediakeysession-generaterequest
Capital at the beginning, period at the end.
> Source/WebCore/Modules/encryptedmedia/InitDataRegistry.cpp:160
> + if (buffer.isEmpty() || buffer.size() > kWebmMaxContentEncKeyIDSize)
> + return std::nullopt;
> + keyIDs.append(buffer.copy());
Instead of this, I'd try to sanitize and if the result is null, bailout. Otherwise, move the WTFMove the result inside the append
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180919/d62b0c2d/attachment-0001.html>
More information about the webkit-unassigned
mailing list