[Webkit-unassigned] [Bug 188568] [GTK][WPE] Implement subprocess sandboxing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188568

--- Comment #54 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Carlos Garcia Campos from comment #47)
> (In reply to Patrick Griffis from comment #45)
> > (In reply to Carlos Garcia Campos from comment #40)
> > > > Source/WebKit/UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:143
> > > > +        Vector<CString> bwrapArgs = {
> > > 
> > > Why are we using Vector<CString>? that means we are duplicating every string
> > > (most of them are static or already owned by the class), and then copied
> > > again in argsToFd.
> > 
> > No reason, do you mean it should be a Vector<char*>?
> 
> Yes, or even char** allocated with g_newa, but we don't need to duplicate
> all the strings

Nevermind, I see now that we have other cases where the string is local to a helper function, so I guess we have to copy them anyway.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180918/6bcbc4f7/attachment.html>