[Webkit-unassigned] [Bug 5968] Add support for spreadMethod=reflect and repeat on SVG gradients (for CoreGraphics platforms)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5968

--- Comment #17 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349809
  --> https://bugs.webkit.org/attachment.cgi?id=349809
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349809&action=review

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:144
> +                    // Find first gradient position to the left of the bounding box
> +                    int n = CGFloor((boundingBox.origin.x - gradientStart) / width);
> +                    gradientStart += n * width;
> +                    if (!(n % 2))
> +                        flip = false;

I think your first version of this patch where you manually do the left side then the right side was much more understandable than this. I can't convince myself that this code is correct.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180914/312e7222/attachment-0001.html>