[Webkit-unassigned] [Bug 184307] Custom elements can lose its JS wrapper and become HTMLUnknownElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 14 00:14:39 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=184307

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yusukesuzuki at slowstart.org

--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
This is VERY strange. Even if I leaked every custom element's JS wrapper by adding it as a property to the global object using a private name, inline wrappers are not there. Maybe somehow we're failing to create a JS element wrapper in some cases???

Index: Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
===================================================================
--- Source/WebCore/bindings/js/JSDOMWindowCustom.cpp    (revision 236001)
+++ Source/WebCore/bindings/js/JSDOMWindowCustom.cpp    (working copy)
@@ -70,11 +70,13 @@
 {
     if (Frame* frame = wrapped().frame())
         visitor.addOpaqueRoot(frame);
-    
+
     // Normally JSEventTargetCustom.cpp's JSEventTarget::visitAdditionalChildren() would call this. But
     // even though DOMWindow is an EventTarget, JSDOMWindow does not subclass JSEventTarget, so we need
     // to do this here.
     wrapped().visitJSEventListeners(visitor);
+
+    CustomElementReactionQueue::visitEnqueuedElements(visitor);
 }

 #if ENABLE(USER_MESSAGE_HANDLERS)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180914/6200294c/attachment.html>


More information about the webkit-unassigned mailing list