[Webkit-unassigned] [Bug 189545] [GTK] Make script dialogs modal to the current web view only

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189545

--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #5)
> Based on the screenshots, I think we should try harder with the theming
> here. I know it's hard....

I don't think they are that different.

> To get the dialogs to look like those created by GTK, we need to set a
> widget path, like we do in createStyleContext() in RenderThemeGtk.cpp.

We already do that, but this case is even more complicated, because we are using real widgets, that create their own style context. We use a custom style context to render the background, but real widget style contexts don't inherit from it. 

Feel free to fight with the theming yourself if it's important for you. For me it's more important to *finally* have non-modal js dialogs.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180914/256e1e4a/attachment.html>