[Webkit-unassigned] [Bug 189591] New: Add ASSERT() to FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite() to fix clang static analyzer warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 13 10:46:31 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=189591

            Bug ID: 189591
           Summary: Add ASSERT() to
                    FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite(
                    ) to fix clang static analyzer warnings
           Product: WebKit
           Version: Safari 10
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: mark.lam at apple.com

FTL::DFG::LowerDFGToB3::compileAtomicsReadModifyWrite() assumes `numExtraArgs` is always greater than zero, but the clang static analyzer assumes it could be zero and emits warnings.

To fix this, add an `ASSERT(numExtraArgs)` statement so that the static analyzer doesn't assume `numExtraArgs` is zero below that statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180913/403125b6/attachment.html>


More information about the webkit-unassigned mailing list