[Webkit-unassigned] [Bug 189579] New: Build error in ImageBufferCG when compiled with IOSurfacePool

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189579

            Bug ID: 189579
           Summary: Build error in ImageBufferCG when compiled with
                    IOSurfacePool
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: fred.wang at free.fr
                CC: lforschler at apple.com
            Blocks: 188043

Applying attachment 349536, I get the errors below on macOS and iOS ports, the unified file is:

#include "platform/graphics/cg/IOSurfacePool.cpp"
#include "platform/graphics/cg/ImageBufferCG.cpp"
#include "platform/graphics/cg/ImageBufferDataCG.cpp"
#include "platform/graphics/cg/ImageDecoderCG.cpp"
#include "platform/graphics/cg/IntPointCG.cpp"
#include "platform/graphics/cg/IntRectCG.cpp"
#include "platform/graphics/cg/IntSizeCG.cpp"
#include "platform/graphics/cg/NativeImageCG.cpp"

IOSurfacePool includes IOSurface.h a first time without defining IOSURFACE_CANVAS_BACKING_STORE
ImageBufferCG includes IOSurface.h again but defining IOSURFACE_CANVAS_BACKING_STORE (this second include is ignored because of the #pragma once directive)

This is causing IOSurface::createFromImageBuffer to become undefined:

In file included from /Users/fred/WebKit/WebKitBuild/Debug/DerivedSources/WebCore/unified-sources/UnifiedSource329.cpp:2:
./platform/graphics/cg/ImageBufferCG.cpp:305:48: error: no member named
      'createFromImageBuffer' in 'WebCore::IOSurface'
    return IOSurface::sinkIntoImage(IOSurface::createFromImageBuffer(WTF...
                                    ~~~~~~~~~~~^
./platform/graphics/cg/ImageBufferCG.cpp:348:71: error: no member named
      'createFromImageBuffer' in 'WebCore::IOSurface'
    RetainPtr<CGImageRef> image = IOSurface::sinkIntoImage(IOSurface::create...
                                                           ~~~~~~~~~~~^
2 errors generated.


Referenced Bugs:

https://bugs.webkit.org/show_bug.cgi?id=188043
[Bug 188043] Add support for ScrollOptions' ScrollBehavior and CSS scroll-behavior properties
-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180913/fd058b84/attachment-0001.html>