[Webkit-unassigned] [Bug 189545] [GTK] Make script dialogs modal to the current web view only

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189545

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 349543 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349543&action=review
> 
> Could you show before/after screenshots for both dialogs?

I'll take screenshots, I tried to make the dialogs as close as possible to the old ones, but GTK+ theming is so hard...

> And does this make the text selectable?

No, I tried, but it affected the focus for some reason. Going to a different tab and back to the one with the alert made the label focused (with the text selected) instead of the default button.

> > Source/WebCore/platform/gtk/po/POTFILES.in:32
> > -../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogGtk.cpp
> > +../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogImpl.cpp
> 
> Wow, you remembered... you're a translation hero, now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180913/7d029ee8/attachment.html>