[Webkit-unassigned] [Bug 189058] [WPE][GTK] webkit-flatpak intercepts --help for other commands

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189058

--- Comment #2 from Alicia Boya García <aboya at igalia.com> ---
run-webkit-tests:
flatpakutils.run_in_sandbox_if_available(sys.argv)

|
v

flatpakutils.py:
def run_in_sandbox_if_available(args):
    [...]
    flatpak_runner = WebkitFlatpak.load_from_args(args)

|
v

flatpakutils.py:
@staticmethod
def load_from_args(args=None):
    [...] # creates a webkit-flatpak's ArgumentParser
    _, self.args = parser.parse_known_args(args=args, namespace=self)

What is `args` in run_in_sandbox_if_available() supposed to be? On the first invocation I would assume it is the command to be executed, but it's (also?) being parsed as the flags to webkit-flatpak. That's strange to say the least.

It seems like the code is trying to mix flatpak flags with the flags for the wrapped executable (we could call it the «flatpakee»?). This was probably intended to make it easy to set flags for both, but it's quite dangerous and as we are seeing now, can't cope with conflicts.

I think run-webkit-tests is doing too much, acting as both the wrapper and the wrapped, and that makes it confusing and creates these conflicts.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180912/27ec690d/attachment.html>