[Webkit-unassigned] [Bug 188996] Add IGNORE_WARNING_.* macros

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188996

--- Comment #43 from Guillaume Emont <guijemont at igalia.com> ---
(In reply to Darin Adler from comment #42)
> > Source/WTF/wtf/Compiler.h:419
> > +#if !defined(IGNORE_GCC_WARNING_BEGIN) && COMPILER(GCC)
> 
> If seems that we have extra #if !defined guards. Does someone need to
> override these macros with definitions done before including this source
> file? We could add that feature (allowing an override) later if we need it;
> I am pretty sure we don’t need it and I would prefer to omit the guards
> except in cases where we use them to avoid complex #else constructions.

I used the if !defined() mainly to match the other macro definitions in the file, but I'm not particularly attached to it, so I removed it in my new version. I left the ones in the other macro definitions though, should I remove them?

I also applied all your other suggestions. Thanks for the thoughtful review!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180911/c3e13300/attachment-0001.html>