[Webkit-unassigned] [Bug 189506] Add missing #if ENABLE(VIDEO) WebProcess/FullScreen/WebFullScreenManager.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189506

--- Comment #7 from Pablo Saavedra <psaavedra at igalia.com> ---
(In reply to Tim Horton from comment #2)
> Comment on attachment 349412 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349412&action=review
> 
> > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102
> > +#if ENABLE(VIDEO)
> 
> !ENABLE(VIDEO) knows what HTMLVideoElement is, though??

(In reply to Tim Horton from comment #2)
> Comment on attachment 349412 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=349412&action=review
> 
> > Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:102
> > +#if ENABLE(VIDEO)
> 
> !ENABLE(VIDEO) knows what HTMLVideoElement is, though??

WebCore/html/HTMLVideoElement.h

Yes, it seems HTMLVideoElement is declared in the Webcore namespace in the top `WebKit/WebProcess/FullScreen/WebFullScreenManager.h`

namespace WebCore {
class IntRect;
class Element;
class GraphicsLayer;
class HTMLVideoElement;
}

Since HTMLVideoElement is not actually used in a statement but in a declaration in the signature of the function is the reason why is valid.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180911/425c8f9c/attachment.html>