[Webkit-unassigned] [Bug 5968] Add support for spreadMethod=reflect and repeat on SVG gradients (for CoreGraphics platforms)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=5968

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #349405|review?                     |review+
              Flags|                            |

--- Comment #12 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 349405
  --> https://bugs.webkit.org/attachment.cgi?id=349405
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349405&action=review

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:118
> +                FloatPoint gradientVectorNorm(data.point1 - data.point0);

Normally we'd use a FloatSize to represent the delta between two points, but sadly we haven't implemented .dot() for FloatSize.

> Source/WebCore/platform/graphics/cg/GradientCG.cpp:120
> +                CGFloat angle = acos(gradientVectorNorm.dot(FloatPoint(1, 0)));

Rather than FloatPoint(1, 0) you can say { 1, 0 } to let the compiler deduce the type.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180911/126fb8ad/attachment.html>