[Webkit-unassigned] [Bug 189500] Add missing #if ENABLE(VIDEO) Page.cpp and Page.h

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189500

--- Comment #5 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 349395
  --> https://bugs.webkit.org/attachment.cgi?id=349395
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349395&action=review

> Source/WebCore/ChangeLog:8
> +          error: 'MediaElementSession' has not been declared

These explanations should be between "Reviewed by NOBODY (OOPS!)." and the filename list.

> Source/WebCore/page/Page.cpp:1525
>  void Page::playbackControlsManagerUpdateTimerFired()

Would it be ok to just #if ENABLE(VIDEO) inside Page::playbackControlsManagerUpdateTimerFired?
It might remove the need for the other #if/#endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180911/2c8b707f/attachment.html>