[Webkit-unassigned] [Bug 189443] Implement the Web Share API for mac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189443

--- Comment #11 from Tim Horton <thorton at apple.com> ---
Comment on attachment 349322
  --> https://bugs.webkit.org/attachment.cgi?id=349322
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349322&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:-204
> -#if PLATFORM(MAC) && ENABLE(DRAG_SUPPORT)

I don't think you meant to remove this existing code.

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.h:31
> +#if PLATFORM(IOS)
> +#import <UIKit/UIKit.h>
> +#endif
> +

Should go below the other headers.

> Source/WebKit/UIProcess/Cocoa/WKShareSheet.mm:43
> +#if PLATFORM(MAC)

the #if here could go just around the members, not around the @implementation or curly braces

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:30
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:194
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:286
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:793
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4739
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:4751
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5920
> +#if PLATFORM(COCOA) && !PLATFORM(WATCHOS) && !PLATFORM(APPLETV)

Not needed here, this file is already PLATFORM(IOS) only. (you still need the existing checks, but don't need to add a cocoa check).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180910/62e027e0/attachment.html>