[Webkit-unassigned] [Bug 189335] [RunLoopGeneric] OneShotTimer should not remain "isActive" after fired

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189335

--- Comment #13 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 349292
  --> https://bugs.webkit.org/attachment.cgi?id=349292
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=349292&action=review

> Source/WTF/wtf/generic/RunLoopGeneric.cpp:54
>          if (!m_isRepeating)
> -            return false;
> +            deactivate();

Why do we deactivate the timer before `m_function()` is called?
Cocoa RunLoop says "A non-repeating timer is automatically invalidated after it fires.".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180910/f105b9dd/attachment.html>