[Webkit-unassigned] [Bug 116046] For keyboard users, activating a fragment URL should transfer focus and caret to the destination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=116046

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |simon.fraser at apple.com

--- Comment #61 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 280814
  --> https://bugs.webkit.org/attachment.cgi?id=280814
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=280814&action=review

> Source/WebCore/dom/Document.cpp:3724
> +        setFocusNavigationStartingNode(focusedElement);

This can set the m_focusNavigationStartingNode to the Document itself, creating a ref cycle.

> Source/WebCore/dom/Document.cpp:4054
> +    removeFocusNavigationNodeOfSubtree(container, true /* amongChildrenOnly */);

There are two other callers of removeFocusedNodeOfSubtree(), in Element::removeShadowRoot() and FrameLoader::clear(). Do they also need to call removeFocusNavigationNodeOfSubtree()? Do we need a function that does both?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180908/c4c9d1e7/attachment.html>