[Webkit-unassigned] [Bug 188742] [GLIB] Expose JavaScriptCore options in GLib public API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=188742

--- Comment #10 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 349021
  --> https://bugs.webkit.org/attachment.cgi?id=349021
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=349021&action=review

There's just one tiny typo, otherwise LGTM. Regarding the list of
options for which it may be interesting to provide documented symbols,
after taking a look at “Options.h”, I would start with the following
(all of them I *think* are unlikely to disappear any time soon):

  - dumpOptions: Useful to see what's enabled/disabled, because
    options can have implications, and (un)setting some of them
    can trigger switching others.

  - configFile: Well, handy to set many options at once *and* the
    location of the JSC log file, which AFAIK cannot be set in any
    other way.

  - useJIT: Because applications which don't do much JS may want
    to have a one-stop option to disable the whole JIT machinery
    and save some resources (e.g. embedding a Web view in an e-mail
    client, where there shouldn't be ever many scripts.)

  - useWebAssembly: I guess some applications may want to disable
    the WebAssembly machinery. Not super sure about this one, though.

It would be interesting to have some feedback from people who work
more often in JSC on the list above, maybe Caitlin and/or Yusuke have
some suggestions.

> Source/JavaScriptCore/API/glib/JSCOptions.cpp:37
> + * Only a few of them are documented, you can use the undocummented options at

Typo, accidental double “m”: undocummented → undocumented

> Source/JavaScriptCore/API/glib/JSCOptions.cpp:484
> + * format <emphasis>[!]<low>[:<high>]</emphasis> where low and high are #guint values.

I see you used <emphasis> in the end, which is fine. Good
catch with the XML escaping using &entities; :D

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180907/87e2ce67/attachment.html>