[Webkit-unassigned] [Bug 189135] BenchmarkResults.format should support specifying depth of tests to show.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189135

Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #348999|review?                     |review+
              Flags|                            |

--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 348999
  --> https://bugs.webkit.org/attachment.cgi?id=348999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348999&action=review

r=me with the suggested change.

> Tools/Scripts/webkitpy/benchmark_runner/benchmark_results.py:78
> -                output += cls._format_tests(test['tests'], scale_unit, show_iteration_values, indent=(indent + ' ' * len(test_name)))
> +                output += cls._format_tests(test['tests'], scale_unit, show_iteration_values, None if max_depth is None else max_depth - 1, indent=(indent + ' ' * len(test_name)))

This is such a convoluted way of doing this.
Please just check: "if 'tests' in test and max_depth > 1" above.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180906/afa78e34/attachment.html>