[Webkit-unassigned] [Bug 189300] New: Fix DeferredSourceDump to capture the caller bytecodeIndex instead of CodeOrigin.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 4 23:43:44 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=189300

            Bug ID: 189300
           Summary: Fix DeferredSourceDump to capture the caller
                    bytecodeIndex instead of CodeOrigin.
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: JavaScriptCore
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com

At the time a DeferredSourceDump is instantiated, it captures a CodeOrigin value, which points to a InlineCallFrame in the DFG::Plan's m_inlineCallFrames set.  The DeferredSourceDump may be later used to dump the source of a failed compilation.  The DFG::Plan may have been destructed by then, and since the compilation failed, the InlineCallFrame is also destructed, which means DeferredSourceDump::dump() may be accessing freed memory.

DeferredSourceDump doesn't really need a CodeOrigin.  All it wants is the caller bytecodeIndex for the call to an inlined function.  Hence, we can fix this issue by changing DeferredSourceDump to capture the caller bytecodeIndex instead.

<rdar://problem/39681779>

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180905/93ada718/attachment-0001.html>


More information about the webkit-unassigned mailing list