[Webkit-unassigned] [Bug 189298] New: Update code style guidelines for using namespace inside a namespace definition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=189298

            Bug ID: 189298
           Summary: Update code style guidelines for using namespace
                    inside a namespace definition
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit Website
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: Hironori.Fujii at sony.com
                CC: jond at apple.com

Update code style guidelines for using namespace inside a namespace definition

https://webkit.org/code-style-guidelines/#using-position

> [](#using-position) In implementation files, put all other "using" statements at the beginning of the file, before any namespace definitions and after any "include" statements.
> 
> ###### Right:
> 
> ```cpp
> // HTMLSelectElement.cpp
> 
> using namespace other;
> 
> namespace WebCore {
> 
> } // namespace WebCore
> ```
> 
> ###### Wrong:
> 
> ```cpp
> // HTMLSelectElement.cpp
> 
> namespace WebCore {
> 
> using namespace other;
> 
> } // namespace WebCore
> ```


[webkit-dev] Moving WebCore to unified source builds and style changes.
https://lists.webkit.org/pipermail/webkit-dev/2017-October/029656.html

> 1) Move all “using namespace <name>;” inside the WebCore namespace (they used to be in the global namespace) and change to "using WebCore::<type-name>;” in .mm files.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180905/5f7be4cb/attachment.html>