[Webkit-unassigned] [Bug 189255] New: Web Inspector: InspectorTest.expectException should work with SyncTestSuite

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 3 20:34:19 PDT 2018


https://bugs.webkit.org/show_bug.cgi?id=189255

            Bug ID: 189255
           Summary: Web Inspector: InspectorTest.expectException should
                    work with SyncTestSuite
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mattbaker at apple.com
                CC: inspector-bugzilla-changes at group.apple.com

TestHarness.expectException returns a Promise, making it unsuitable for synchronous tests. There are a couple of options:

1) Do nothing: write tests that need expectException as async tests.
2) Create a separate synchronous version of expectException, with a new name.
3) Have expectException alter its behavior based on the return value of the `work` function.

Option 1 feels oppressive. Option 2 is unsightly, but straightforward. Option 3 is elegant, but obtuse and potentially surprising. I'm leaning toward 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180904/b2095c68/attachment.html>


More information about the webkit-unassigned mailing list