[Webkit-unassigned] [Bug 14590] svn-create-patch fails when svn mv is used on directory trees

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=14590

--- Comment #11 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 348766
  --> https://bugs.webkit.org/attachment.cgi?id=348766
Patch v1 - WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=348766&action=review

> Tools/Scripts/svn-create-patch:355
> +        print STDERR "Performing \"svn diff --diff-cmd diff -x -$diffOptions '$escapedDirectory'\"\n" if $verbose;
> +        open DIFF, "svn diff --diff-cmd diff -x -$diffOptions '$escapedDirectory' |" or die;

The funny part about this command is that it simply lists the new files in the moved directory using patch headers with empty bodies:

$ svn diff --diff-cmd diff -x -uap 'Tools/TestWebKitAPI/Tests/WTF/cocoa'
Index: Tools/TestWebKitAPI/Tests/WTF/cocoa/BlockPtr.mm
===================================================================
Index: Tools/TestWebKitAPI/Tests/WTF/cocoa/RetainPtr.mm
===================================================================

I'm not sure if this is documented or expected behavior, but it was the best way I found to enumerate the files in the moved directory (both new and moved-from-elsewhere).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20180903/1d46c3d7/attachment.html>